Skip to content

Use Redis locking for value retrieval synchronization #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Jul 29, 2024

Draft of using RedisCacheWriter for read-thru caching instead of using a Lock within RedisCache.

Closes #2890

mp911de added 3 commits July 29, 2024 08:52
We now use RedisCacheWriter to acquire and maintain the lock for value retrieval synchronization.
We now correctly apply time to idle on retrievals.
@mp911de mp911de requested a review from christophstrobl July 29, 2024 07:36
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 29, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 22, 2024
@mp911de mp911de marked this pull request as ready for review September 5, 2024 06:51
christophstrobl pushed a commit that referenced this pull request Sep 5, 2024
We now use RedisCacheWriter to acquire and maintain the lock for value retrieval synchronization.

Closes: #2890
Original Pull Request: #2948
christophstrobl pushed a commit that referenced this pull request Sep 5, 2024
We now correctly apply time to idle on retrievals.

Original Pull Request: #2948
christophstrobl added a commit that referenced this pull request Sep 5, 2024
Remove no longer needed wasLocked flag from CacheWriter.

Original Pull Request: #2948
@christophstrobl christophstrobl deleted the issue/2890 branch September 5, 2024 13:10
@mp911de mp911de added this to the 3.4 M1 (2024.1.0) milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisCache.get(Object, Callable) synchronizes on entire cache instead of individual keys
3 participants